Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new argument num_classes to eval scripts #21

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add new argument num_classes to eval scripts #21

wants to merge 13 commits into from

Conversation

fabito
Copy link

@fabito fabito commented May 4, 2021

No description provided.

@facebook-github-bot
Copy link

Hi @fabito!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fabito fabito changed the title Add new argument num_classes to eval_knn script Add new argument num_classes to eval scripts May 4, 2021
@mathildecaron31
Merge pull request facebookresearch#22 from user1234554321/main
5fa73ae 
Add num_labels to eval_linear, change max_accuracy to best_acc
@mathildecaron31
Copy link
Contributor

Hi @fabito
I have just merged another PR dealing with the same issue in eval_linear.py. Can you update your PR accordingly :) ?
Thanks a lot for contributing

@fabito
Copy link
Author

fabito commented May 11, 2021

Done @mathildecaron31

@mathildecaron31 mathildecaron31 force-pushed the main branch 2 times, most recently from ce8632f to 82d28b4 Compare May 13, 2021 17:33
@mathildecaron31
Copy link
Contributor

Please rebase

@ketil-malde
Copy link

Good... but shouldn't this rather be automatically calculated from the number of directories in data_path/val and /train? What happens if I have more directories than num_labels? Or if val and train subdirectories don't match? (I can write the code for this, but would like to know if I misunderstand something here)

@woctezuma
Copy link

The pull request is just there to allow to specify the value of the function argument, which is otherwise used with its default value:

dino/eval_knn.py

Line 143 in cb71140

def knn_classifier(train_features, train_labels, test_features, test_labels, k, T, num_classes=1000):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fabito @facebook-github-bot @mathildecaron31 @ketil-malde @woctezuma @aquadzn @user1234554321